Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: migrate functional-red-black-tree to js-sdsl #5624

Closed
4 tasks done
ZLY201 opened this issue Sep 12, 2022 · 2 comments
Closed
4 tasks done

Enhancement: migrate functional-red-black-tree to js-sdsl #5624

ZLY201 opened this issue Sep 12, 2022 · 2 comments
Labels
enhancement New feature or request triage Waiting for maintainers to take a look

Comments

@ZLY201
Copy link

ZLY201 commented Sep 12, 2022

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

eslint-plugin-tslint

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/

Now, we published the version 4.1.4.

I see you are using functional-red-black-tree.

In benchmark, we have confirmed that Js-sdsl is several times faster than functional-red-black-tree.

I've submitted a PR to eslint and has been accepted.

See eslint/eslint#16255 and eslint/eslint#16267.

I am willing to submit a pull request for this change.

Looking forward to your reply! :D

Fail

none

Pass

none

Additional Info

No response

@ZLY201 ZLY201 added enhancement New feature or request triage Waiting for maintainers to take a look labels Sep 12, 2022
@bradzacher
Copy link
Member

Thanks for the issue!

Whilst we do have it as a dependency, we don't really use the code. It was intended to be part of a complete fork and rewrite of the indent rule to support TS features, but due to time constraints and lack of interest amongst the maintainers it has never actually progressed nor was it ever released.
See #1824

We'll probably delete the chunk of code for now considering it's looking like it's unlikely to be worked on by anyone, which would remove our dependency.

@bradzacher bradzacher closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2022
@bradzacher
Copy link
Member

I have raised #5625 to delete our unused fork.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request triage Waiting for maintainers to take a look
Projects
None yet
Development

No branches or pull requests

2 participants