New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint-plugin): remove unused indent fork #5625
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5625 +/- ##
==========================================
+ Coverage 91.63% 93.59% +1.96%
==========================================
Files 134 288 +154
Lines 1506 9575 +8069
Branches 226 2880 +2654
==========================================
+ Hits 1380 8962 +7582
- Misses 62 334 +272
- Partials 64 279 +215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be nice for the install size!
PR Checklist
Overview
We ship all of this code with our releases, even though it's not possible for someone to actually use the rule.
This fork has been in the codebase for over 3 years (#439). The issue (#1824) has been open asking for help for over 2 years.
The latest version of the core lint rule (released in ESLint v8.23.1) no longer uses the
functional-red-black-tree
package, so we also now install a unique dependency that we don't actually use. Previously this was fine because ESLint core used it, but it's no longer going to be the case!I'm comfortable removing this unused code entirely at this time.
When (if) a community member decides to help us with the fork, they can start by reverting this PR as the base for the work, though they'll probably want to just freshly fork the core rule and work from there, rather than attempting to merge 3 years of upstream changes into this dead code.
This saves us from having to maintain almost 12k lines of code!