Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint-plugin): remove unused indent fork #5625

Merged
merged 1 commit into from Sep 13, 2022
Merged

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 12, 2022

PR Checklist

Overview

We ship all of this code with our releases, even though it's not possible for someone to actually use the rule.

This fork has been in the codebase for over 3 years (#439). The issue (#1824) has been open asking for help for over 2 years.
The latest version of the core lint rule (released in ESLint v8.23.1) no longer uses the functional-red-black-tree package, so we also now install a unique dependency that we don't actually use. Previously this was fine because ESLint core used it, but it's no longer going to be the case!

I'm comfortable removing this unused code entirely at this time.
When (if) a community member decides to help us with the fork, they can start by reverting this PR as the base for the work, though they'll probably want to just freshly fork the core rule and work from there, rather than attempting to merge 3 years of upstream changes into this dead code.

This saves us from having to maintain almost 12k lines of code!

@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Sep 12, 2022
@nx-cloud
Copy link

nx-cloud bot commented Sep 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f6eaefc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f6eaefc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/631ecd2bde4d4e00098062b4
😎 Deploy Preview https://deploy-preview-5625--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #5625 (f6eaefc) into main (bd4a7a6) will increase coverage by 1.96%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5625      +/-   ##
==========================================
+ Coverage   91.63%   93.59%   +1.96%     
==========================================
  Files         134      288     +154     
  Lines        1506     9575    +8069     
  Branches      226     2880    +2654     
==========================================
+ Hits         1380     8962    +7582     
- Misses         62      334     +272     
- Partials       64      279     +215     
Flag Coverage Δ
unittest 93.59% <ø> (+1.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/prefer-as-const.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts 93.39% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <0.00%> (ø)
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 97.95% <0.00%> (ø)
...gin/src/rules/non-nullable-type-assertion-style.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-readonly.ts 99.08% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-loop-func.ts 98.11% <0.00%> (ø)
packages/eslint-plugin/src/configs/strict.ts 100.00% <0.00%> (ø)
...c/rules/no-non-null-asserted-nullish-coalescing.ts 91.66% <0.00%> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts 100.00% <0.00%> (ø)
... and 144 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be nice for the install size!

@bradzacher bradzacher changed the title chore: remove unused indent fork chore(eslint-plugin): remove unused indent fork Sep 13, 2022
@bradzacher bradzacher merged commit 5d0bf1c into main Sep 13, 2022
@bradzacher bradzacher deleted the delete-indent-fork branch September 13, 2022 12:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants