fix(eslint-plugin): [no-unsafe-enum-comparison] exempt bit shift operators

[Melandra]

PR Checklist

• Addresses an existing open issue: fixes Bug: no-unsafe-enum-comparison - False positives with bit shifts #7067
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Exempts the bit shift operators << and >> from the no-unsafe-enum-comparison rule.

[typescript-eslint]

Thanks for the PR, @Melandra!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	1d286cb
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64b589a54d48fa00085ae7e0
😎 Deploy Preview	https://deploy-preview-7074--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1d286cb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 35 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx test typescript-estree --coverage=false
• nx run types:build
• nx test eslint-plugin-tslint --coverage=false
• nx test eslint-plugin-internal --coverage=false
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx run types:build
• Node 20 - nx test utils
• Node 20 - nx test scope-manager
• Node 20 - nx test visitor-keys
• Node 20 - nx test parser
• Node 20 - nx test type-utils
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test repo-tools
• Node 20 - nx test typescript-estree
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test ast-spec
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• nx run integration-tests:test
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx run types:build
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[JoshuaKGoldberg]

LGTM, thanks for sending! ✨

Just a couple of non-blocking suggestions - what do you think?

[Josh-Cena]

Suggested change

	'BinaryExpression[operator=/=|<|>/]'(
	'BinaryExpression[operator=/^(<>!)?={0,2}$/]'(

...Much simpler? Otherwise you will also need to remember to deal with >>>.

[Melandra]

Thanks for the suggestion, please see 68938c5, I've replaced the regex with ^[<>!=]?={0,2}$ instead to also match ===

[JoshuaKGoldberg]

@Melandra just checking in, did you mean to re-request our review on this one?

[Melandra]

@Melandra just checking in, did you mean to re-request our review on this one?

Yes, I didn't know you were expecting me to re-request the review, sorry 😬

[JoshuaKGoldberg]

Ah we've since added guidance in https://typescript-eslint.io/contributing/pull-requests#addressing-feedback-and-beyond - which I think didn't exist when you first sent this. Thanks!

[JoshuaKGoldberg]

🔥 great, thanks!