fix(eslint-plugin): [no-extra-parens] keep parens around call expression arguments when type arguments contain parens

[auvred]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-extra-parens] False positive when calling generic function with type tuple parameter containing parenthesis #7030
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This issue has a long story

After a little investigation I restored the chronology of changes:

1. This PR introduced fix for this issue fix(eslint-plugin): [no-extra-parens] stop reporting on calling generic functions with one argument and type parameters containing parentheses #2319. Everything worked fine, and there was even a test case for such a situation
   https://github.com/typescript-eslint/typescript-eslint/pull/2319/files#diff-fbb45da7466e6a089a93155bac8bc3e3e16758e9ec33d941286852ed7d64f48bR31

2. In this PR (feat: remove TSParenthesizedType #3340) the TSParenthesizedType was removed
   https://github.com/typescript-eslint/typescript-eslint/pull/3340/files#diff-a916a57c423a9435766d31cbea70b6434185d7f227eaff16df942efaab05b08bR86-R88
   The corresponding test case was also changed (I think this is a kind of regression)
   https://github.com/typescript-eslint/typescript-eslint/pull/3340/files#diff-fbb45da7466e6a089a93155bac8bc3e3e16758e9ec33d941286852ed7d64f48bR30-R32

3. There was added check for TSArrayType fix(eslint-plugin): [no-extra-parens] handle generic ts array type. #5550. But as far as I understand it was just the edge case, because the same code without an array [] turns into a broken one

---

I couldn't find any other way to fix this problem other than checking if there any opening parenthesis between node.callee and first argument (node.arguments[0]). Otherwise eslint/no-extra-parens treats it as an opening parenthesis for the arguments list

Many thanks to this explanation #2314 (comment)

[typescript-eslint]

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	f850fec
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64cea6a1167c3500084a3a72
😎 Deploy Preview	https://deploy-preview-7375--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f850fec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 35 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx test typescript-estree --coverage=false
• nx run types:build
• nx test eslint-plugin-internal --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• Node 20 - nx test utils
• Node 20 - nx run types:build
• Node 20 - nx test visitor-keys
• Node 20 - nx test type-utils
• Node 20 - nx test typescript-estree
• Node 20 - nx test repo-tools
• Node 20 - nx test scope-manager
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test parser
• Node 20 - nx test eslint-plugin-tslint
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx run types:build
• Node 20 - nx test ast-spec
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run-many --target=lint --parallel
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #7375 (c273b85) into main (c869aa1) will increase coverage by 0.01%.
Report is 40 commits behind head on main.
The diff coverage is 64.70%.

❗ Current head c273b85 differs from pull request most recent head f850fec. Consider uploading reports for the commit f850fec to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7375      +/-   ##
==========================================
+ Coverage   87.40%   87.41%   +0.01%     
==========================================
  Files         381      381              
  Lines       13313    13316       +3     
  Branches     3934     3935       +1     
==========================================
+ Hits        11636    11640       +4     
- Misses       1292     1298       +6     
+ Partials      385      378       -7     

Flag	Coverage Δ
unittest	87.41% <64.70%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...kages/scope-manager/src/referencer/ClassVisitor.ts	91.73% <ø> (ø)
packages/type-utils/src/predicates.ts	21.73% <0.00%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts	93.33% <ø> (ø)
packages/typescript-estree/src/convert.ts	30.03% <31.25%> (ø)
...eslint-plugin/src/rules/type-annotation-spacing.ts	83.09% <50.00%> (+1.40%)	⬆️
...eslint-plugin/src/rules/consistent-type-imports.ts	94.50% <100.00%> (ø)
packages/eslint-plugin/src/rules/indent.ts	88.09% <100.00%> (ø)
packages/eslint-plugin/src/rules/key-spacing.ts	99.30% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	91.35% <100.00%> (ø)
...es/eslint-plugin/src/rules/no-floating-promises.ts	100.00% <100.00%> (ø)
... and 10 more

[JoshuaKGoldberg]

What a great PR description - thanks both for the fix and excellent writeup @auvred!