fix(eslint-plugin): [no-restricted-imports] disallow side effect imports when allowTypeImports is enabled

[joshkel]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-restricted-imports] allowTypeImports allows side effect imports #7559
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Fixes #7559 by changing the logic from #7379 from "allow imports if all specifiers are types (or if no specifiers exist)" to "allow imports if specifiers exist and all specifiers are types."

✨

[netlify]

❌ Deploy Preview for typescript-eslint failed.

Name	Link
🔨 Latest commit	b61759b
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64fa703738bf8800085f4afd

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b61759b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

🟥 Failed Commands
nx build website

✅ Successfully ran 39 targets

• nx test eslint-plugin --coverage=false
• Node 20 - nx test eslint-plugin
• Node 16 - nx test eslint-plugin --coverage=false
• nx test eslint-plugin-tslint --coverage=false
• nx run types:build
• nx run repo-tools:postinstall-script
• nx test typescript-estree --coverage=false
• nx test eslint-plugin-internal --coverage=false
• Node 20 - nx test utils
• Node 20 - nx test type-utils
• Node 20 - nx run types:build
• Node 20 - nx test visitor-keys
• Node 20 - nx test parser
• Node 20 - nx run repo-tools:postinstall-script
• Node 20 - nx test typescript-estree
• Node 20 - nx test repo-tools
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test rule-schema-to-typescript-types
• Node 16 - nx test visitor-keys --coverage=false
• Node 16 - nx run types:build
• Node 20 - nx test scope-manager
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test ast-spec
• Node 16 - nx run repo-tools:postinstall-script
• nx run-many --target=typecheck --parallel
• nx run-many --target=lint --parallel
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• nx run integration-tests:test
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• nx run eslint-plugin:generate:configs
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

Merging #7560 (b61759b) into main (4f34d0b) will not change coverage.
Report is 34 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7560   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         387      387           
  Lines       13401    13401           
  Branches     3962     3962           
=======================================
  Hits        11690    11690           
  Misses       1327     1327           
  Partials      384      384           

Flag	Coverage Δ
unittest	87.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...s/eslint-plugin/src/rules/no-restricted-imports.ts	95.71% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=typescript-eslint).

[typescript-eslint]

Thanks for the PR, @joshkel!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[bradzacher]

for completeness - could we also get a valid test case for import 'foo' with no banning config just to sanity-check that it still continues to pass?

otherwise looking good to me! great work!

[joshkel]

for completeness - could we also get a valid test case for import 'foo' with no banning config just to sanity-check that it still continues to pass?

@bradzacher Done (if I've understood correctly). Thanks for the review!

[bradzacher]

thanks for fixing this!