Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-restricted-imports] disallow side effect imports when allowTypeImports is enabled #7560

Merged
merged 3 commits into from Sep 8, 2023
Merged

fix(eslint-plugin): [no-restricted-imports] disallow side effect imports when allowTypeImports is enabled #7560

merged 3 commits into from Sep 8, 2023

Commits on Aug 29, 2023

  1. Disallow side effect imports when allowTypeImports is enabled 

    Fixes #7559
    @joshkel
    joshkel committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    519f594 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
    @joshkel @bradzacher
    joshkel and bradzacher committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d159cef View commit details
    Browse the repository at this point in the history

  2. Add a passing test for "import 'foo'"

    @joshkel
    joshkel committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b61759b View commit details
    Browse the repository at this point in the history