Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript-estree): correct ClassDeclarationBase type #1008

Merged
merged 1 commit into from Sep 25, 2019
Merged

fix(typescript-estree): correct ClassDeclarationBase type #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/eslint-plugin/src/rules/indent.ts
View file
Open in desktop
Expand Up @@ -344,7 +344,7 @@ export default util.createRule<Options, MessageIds>({
]({
type: AST_NODE_TYPES.ClassDeclaration,
body: node.body as any,
id: undefined,
id: null,
// TODO: This is invalid, there can be more than one extends in interface
superClass: node.extends![0].expression as any,

Expand Down
4 changes: 2 additions & 2 deletions packages/typescript-estree/src/ts-estree/ts-estree.ts
View file
Open in desktop
Expand Up @@ -454,9 +454,9 @@ interface BinaryExpressionBase extends BaseNode {
interface ClassDeclarationBase extends BaseNode {
typeParameters?: TSTypeParameterDeclaration;
superTypeParameters?: TSTypeParameterInstantiation;
id?: Identifier;
id: Identifier | null;
body: ClassBody;
superClass?: LeftHandSideExpression;
superClass: LeftHandSideExpression | null;
implements?: ExpressionWithTypeArguments[];
abstract?: boolean;
declare?: boolean;
Expand Down