Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unbound-method): check MemberExpression when parent is CallExpression #1087

Closed
wants to merge 3 commits into from
Closed

fix(unbound-method): check MemberExpression when parent is CallExpression #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3fb18f
fix(unbound-method): check special type when parent is CallExpression
komkanit Oct 15, 2019
9dc63a8
Merge branch 'master' into fix-console-method-bound
komkanit Oct 15, 2019
a724fc2
Merge branch 'master' into fix-console-method-bound
komkanit Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/eslint-plugin/src/rules/unbound-method.ts
View file
Open in desktop
Expand Up @@ -109,6 +109,9 @@ function isSafeUse(node: TSESTree.Node): boolean {
return true;

case AST_NODE_TYPES.CallExpression:
if (node.type === AST_NODE_TYPES.MemberExpression) {
return true;
}
return parent.callee === node;

case AST_NODE_TYPES.ConditionalExpression:
Expand Down
3 changes: 3 additions & 0 deletions packages/eslint-plugin/tests/rules/unbound-method.test.ts
View file
Open in desktop
Expand Up @@ -15,6 +15,9 @@ const ruleTester = new RuleTester({
ruleTester.run('unbound-method', rule, {
valid: [
`
new Promise(() => {}).then(console.log)
`,
`
class ContainsMethods {
bound?: () => void;
unbound?(): void;
Expand Down