Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): ensure parent pointers are set #1129

Merged
merged 2 commits into from Oct 25, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1125

I (stupidly) forgot to mirror the code exactly when I set up the short-circuit return.

@bradzacher bradzacher added the bug Something isn't working label Oct 23, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #1129 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1129      +/-   ##
==========================================
+ Coverage   94.07%   94.07%   +<.01%     
==========================================
  Files         120      120              
  Lines        5214     5217       +3     
  Branches     1443     1443              
==========================================
+ Hits         4905     4908       +3     
  Misses        177      177              
  Partials      132      132
Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 93.29% <100%> (+0.12%) ⬆️

@bradzacher bradzacher merged commit d4703e1 into master Oct 25, 2019
@bradzacher bradzacher deleted the no-node-parent branch October 25, 2019 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.5.0] 0:0 Parsing error: Cannot read property 'name' of undefined
1 participant