Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [interface-name-prefix] add replacePrefixI option #1154

Closed

Conversation

shaodahong
Copy link
Contributor

Closed #1145

I use a new option replacePrefixI, that value may be replaced default prefix I

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @shaodahong!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Oct 29, 2019
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1154 into master will decrease coverage by 0.04%.
The diff coverage is 61.53%.

@@            Coverage Diff            @@
##           master   #1154      +/-   ##
=========================================
- Coverage   94.05%     94%   -0.05%     
=========================================
  Files         123     123              
  Lines        5283    5289       +6     
  Branches     1468    1471       +3     
=========================================
+ Hits         4969    4972       +3     
- Misses        179     180       +1     
- Partials      135     137       +2
Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/interface-name-prefix.ts 76.66% <61.53%> (-6.67%) ⬇️

@bradzacher
Copy link
Member

Thanks for the PR.
This is instead being handled via #1318

@bradzacher bradzacher closed this Dec 10, 2019
@shaodahong shaodahong deleted the feat-use-custom-prefix branch December 11, 2019 01:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[interface-name-prefix] Allow to set custom prefix
2 participants