Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-unnecessary-condition] remove option ignoreRHS #1163

Merged
merged 2 commits into from May 9, 2020

Commits on Jan 28, 2020

  1. feat(eslint-plugin): [no-unnecessary-condition] remove ignoreRHS option

    The 'ignoreRHS' option was an unnecessary part of this lint rule; it forced the user to choose between false-negatives (e.g. if(expr && true)) or false positives `return expr && <ReactComponent>`.
    
    The new logic only checks the right hand side of a logical operator if the logical expression is in a conditional context: e.g. it's inside an if block, or it's the left hand side of another logical expression.
    Retsam committed Jan 28, 2020
    Copy the full SHA
    335132a View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Merge branch 'v3' into pr/Retsam/1163

    # Conflicts:
    #	packages/eslint-plugin/src/rules/no-unnecessary-condition.ts
    #	packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
    bradzacher committed May 9, 2020
    Copy the full SHA
    9066830 View commit details
    Browse the repository at this point in the history