Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [require-await] crash when await is used outside of async #1212

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1077

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #1212 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   94.15%   94.15%   +<.01%     
==========================================
  Files         124      124              
  Lines        5334     5337       +3     
  Branches     1491     1492       +1     
==========================================
+ Hits         5022     5025       +3     
  Misses        178      178              
  Partials      134      134
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/require-await.ts 93.18% <100%> (+0.49%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Nov 15, 2019
@bradzacher bradzacher changed the title fix(eslint-plugin): fix rule crash when await is used outside of async fix(eslint-plugin): [require-await] crash when await is used outside of async Nov 15, 2019
@bradzacher
Copy link
Member

See: #1077 (comment)

@bradzacher bradzacher closed this Nov 15, 2019
@a-tarasyuk a-tarasyuk deleted the bug/1077-require-await-throws branch November 15, 2019 18:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[require-await] throws
2 participants