Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type-name-prefix rule #1329

Closed
wants to merge 1 commit into from
Closed

feat: add type-name-prefix rule #1329

wants to merge 1 commit into from

Conversation

ardevelop
Copy link

Similarly to existent interface-name-prefix, the rule is intended to support team agreements on prefixing type names.

There are 2 options for prefixWithT setting:

  • always: enforce all type names to be prefixed by T
  • never: enforce all type names NOT to be prefixed by T

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ardevelop!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@ardevelop ardevelop changed the title Add type-name-prefix rule feat: add type-name-prefix rule Dec 13, 2019
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1329 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +0.01%     
==========================================
  Files         131      132       +1     
  Lines        5840     5850      +10     
  Branches     1652     1653       +1     
==========================================
+ Hits         5486     5496      +10     
  Misses        189      189              
  Partials      165      165
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️
...ckages/eslint-plugin/src/rules/type-name-prefix.ts 100% <100%> (ø)

@bradzacher
Copy link
Member

Hey there, thanks for the PR.

We're not looking to add more naming rules, and are instead standardising all of the rules into a single rule - see #1318

@bradzacher bradzacher closed this Dec 13, 2019
@ardevelop ardevelop deleted the add-type-name-prefix-rule branch December 13, 2019 12:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants