fix(typescript-estree): persisted parse and module none

[armano2]

This is alternative (more extensive) change to how converter generates AST, this change simply removes needs of parent propagation for conversion logic.

This change contains history from #1516, and its described in #1516 (comment)

fixes #1502

[bradzacher]

I think this is a net positive.
It adds a small amount of complexity, but it means we can never mess it up by forgetting a getTypeChecker call

[bradzacher]

do we need to set this now?

[armano2]

should not be needed anymore

[bradzacher]

ditto

[codecov]

Codecov Report

Merging #1521 into master will decrease coverage by 0.07%.
The diff coverage is 97%.

@@            Coverage Diff             @@
##           master    #1521      +/-   ##
==========================================
- Coverage   95.57%   95.49%   -0.08%     
==========================================
  Files         149      150       +1     
  Lines        6685     6636      -49     
  Branches     1913     1878      -35     
==========================================
- Hits         6389     6337      -52     
  Misses        112      112              
- Partials      184      187       +3

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	99.43% <100%> (ø)	⬆️
.../eslint-plugin/src/util/explicitReturnTypeUtils.ts	100% <100%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts	100% <100%> (ø)	⬆️
packages/eslint-plugin/src/util/astUtils.ts	84.37% <80%> (-3.13%)	⬇️
...plugin/src/rules/explicit-module-boundary-types.ts	85.45% <94.44%> (-8.52%)	⬇️

[armano2]

make sure to validate all lines if i'm passing correct property as parent (i know its huge)

[bradzacher]

I eyeballed it all and it looked fine.
I'd hope that the tests would break if there was something you got wrong.
Seeing green so I think you got it all.

[bradzacher]

TBF as well, there's only 6 instances of parent. in convert.ts.
So there's only a few cases to check.
Might be worth triple checking that there are tests covering these cases

[armano2]

I did some additional testing, and it seems that we need parent nodes, than this change is not going to work,

.parent is mostly used by tsutils and if i turn off parent nodes its starting to fail

---

first place where it actually fails is comment generation as this relies on parents, i will recommend for now just go with #1516 or some variation of it (mayby we could limit number of calls by checking if first node has parent?)

[bradzacher]

😢

That sucks. I didn't even think about the fact that tsutils uses parent.
Okay. reopen that and we can go with it instead.

[armano2]

than i'm closing this one as it will not work 😿