Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): add new node type TSUnknownJSDocType #1541

Closed
wants to merge 2 commits into from
Closed

feat(typescript-estree): add new node type TSUnknownJSDocType #1541

wants to merge 2 commits into from

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 29, 2020

This node can be produced only in few cases when code has invalid syntax

export interface TSUnknownJSDocType extends BaseNode {
  type: AST_NODE_TYPES.TSUnknownJSDocType;
  kind:
    | 'JSDocAllType'
    | 'JSDocUnknownType'
    | 'JSDocFunctionType'
    | 'JSDocNullableType'
    | 'JSDocNonNullableType';
  value: string;
}

I'm not sure about name, TSUnknownJSDocType, TSInvalidJSDocType or more generic TSInvalidType

unblocks prettier/prettier#7463
fixes regression introduced in #1525

This node can be produced only in few cases when code has invalid syntax
@armano2 armano2 added bug Something isn't working enhancement New feature or request labels Jan 29, 2020
@armano2 armano2 self-assigned this Jan 29, 2020
@typescript-eslint

This comment has been minimized.

@armano2 armano2 requested review from bradzacher and removed request for bradzacher January 29, 2020 19:56
@armano2 armano2 added the DO NOT MERGE PRs which should not be merged yet label Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1541 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1541      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files         151      151              
  Lines        6683     6682       -1     
  Branches     1891     1889       -2     
==========================================
- Hits         6373     6372       -1     
  Misses        118      118              
  Partials      192      192
Impacted Files Coverage Δ
packages/typescript-estree/src/visitor-keys.ts 100% <ø> (ø) ⬆️
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts 0% <ø> (ø) ⬆️
packages/typescript-estree/src/convert.ts 99.42% <100%> (-0.01%) ⬇️
.../typescript-estree/src/ts-estree/ast-node-types.ts 100% <100%> (ø) ⬆️

@armano2 armano2 closed this Jan 29, 2020
@armano2
Copy link
Member Author

armano2 commented Jan 29, 2020

closed in favor of #1543

@armano2 armano2 deleted the jsdoc-types branch January 29, 2020 21:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working DO NOT MERGE PRs which should not be merged yet enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant