Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dependencies #1549

Closed
wants to merge 5 commits into from
Closed

chore: bump dependencies #1549

wants to merge 5 commits into from

Conversation

bradzacher
Copy link
Member

lint-staged is the only one I didn't bump, because they dropped support for node 8, and we still support it. I think most people work in here on node 10/12, but I figured that it's probably best to just wait till we drop support too.

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Jan 30, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher
Copy link
Member Author

Ahhh phooey.
I thought my PR (eslint/eslint#12715) had been released, but it was merged a few days late, so it's going to be in the 7.0 release instead.

I'll have to revert all of my changes, or bump to eslint 7.0.0-alpha.0
https://github.com/eslint/eslint/releases/tag/v7.0.0-alpha.0

@armano2
Copy link
Member

armano2 commented Jan 31, 2020

seems that integration tests did fail again:

typescript-and-tslint-plugins-together    | Failed to load plugin '@typescript-eslint' declared in '--config': createRequire is not a function
typescript-and-tslint-plugins-together    | Referenced from: /usr/linked/.eslintrc.yml
typescript-and-tslint-plugins-together    | FAIL ./test.js
typescript-and-tslint-plugins-together    |   ● Test suite failed to run
typescript-and-tslint-plugins-together    | 
typescript-and-tslint-plugins-together    |     Cannot find module './lint-output.json' from 'test.js'
typescript-and-tslint-plugins-together    | 
typescript-and-tslint-plugins-together    |     > 1 | const actualLintOutput = require('./lint-output.json');
typescript-and-tslint-plugins-together    |         |                                  ^
typescript-and-tslint-plugins-together    |       2 |  
typescript-and-tslint-plugins-together    |       3 |  test('it should produce the expected lint ouput', () => {
typescript-and-tslint-plugins-together    |       4 |    expect(actualLintOutput).toMatchSnapshot();
typescript-and-tslint-plugins-together    | 
typescript-and-tslint-plugins-together    |       at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:276:11)
typescript-and-tslint-plugins-together    |       at Object.<anonymous> (test.js:1:34)

restarted

@bradzacher
Copy link
Member Author

weird... the integration tests aren't working at all..

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #1549 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1549   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         148      148           
  Lines        6968     6971    +3     
  Branches     2009     2010    +1     
=======================================
+ Hits         6633     6636    +3     
  Misses        124      124           
  Partials      211      211           
Flag Coverage Δ
#unittest 95.19% <ø> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/no-unused-expressions.ts 100.00% <ø> (ø)
packages/experimental-utils/src/json-schema.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 99.15% <0.00%> (ø)
packages/eslint-plugin/src/rules/quotes.ts 94.11% <0.00%> (ø)
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.10% <0.00%> (+0.13%) ⬆️

@bradzacher bradzacher closed this Apr 4, 2020
@bradzacher
Copy link
Member Author

This needs work.

@bradzacher bradzacher deleted the bump-deps-20190130 branch April 30, 2020 07:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants