New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [unbound-method] ignore assignments _to_ methods #1736
fix(eslint-plugin): [unbound-method] ignore assignments _to_ methods #1736
Conversation
Thanks for the PR, @Zzzen! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for this
Codecov Report
@@ Coverage Diff @@
## master #1736 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 162 162
Lines 7490 7491 +1
Branches 2148 2149 +1
=======================================
+ Hits 7077 7078 +1
Misses 178 178
Partials 235 235
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry - there were a few lint changes that are firing on this PR.
fix them up and we can merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!
* Added url helper to listing service to make url slugs from listing * Minor version bump on typescript-eslint plugin to get fixes from typescript-eslint/typescript-eslint#1736 * Added routing with url slug for listings + a redirect from the id path
closes #1256