Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn on plugin-test-formatting rule #1822

Merged
merged 92 commits into from Mar 31, 2020

Conversation

bradzacher
Copy link
Member

Went through every test and fixed the output.
Took forever, but now that it's done it's done.

NOTE - built on top of #1821

@bradzacher bradzacher added blocked by another PR PRs which are ready to go but waiting on another PR repo maintenance things to do with maintenance of the repo, and not with code/docs labels Mar 30, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher force-pushed the internal-lint-test-formatting branch from 91ecd4b to 8a4396c Compare March 30, 2020 07:42
@bradzacher bradzacher force-pushed the turn-on-internal-lint-test-formatting branch from 020c4cd to d140f77 Compare March 30, 2020 07:43
@bradzacher bradzacher force-pushed the internal-lint-test-formatting branch from a6fcb8d to 51d563a Compare March 30, 2020 08:43
@bradzacher bradzacher changed the base branch from internal-lint-test-formatting to master March 30, 2020 19:05
@bradzacher bradzacher force-pushed the turn-on-internal-lint-test-formatting branch from a38d090 to 05edf30 Compare March 30, 2020 19:07
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #1822 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1822   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files         160      160           
  Lines        7263     7263           
  Branches     2081     2081           
=======================================
  Hits         6874     6874           
  Misses        167      167           
  Partials      222      222           
Flag Coverage Δ
#unittest 94.64% <0.00%> (ø)

@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label Mar 30, 2020
@bradzacher bradzacher force-pushed the turn-on-internal-lint-test-formatting branch from 05edf30 to ce63ed2 Compare March 31, 2020 00:08
@bradzacher bradzacher marked this pull request as ready for review March 31, 2020 00:13
@bradzacher bradzacher force-pushed the turn-on-internal-lint-test-formatting branch from ce63ed2 to dfb97cd Compare March 31, 2020 04:33
@bradzacher bradzacher merged commit 188b689 into master Mar 31, 2020
@bradzacher bradzacher deleted the turn-on-internal-lint-test-formatting branch March 31, 2020 06:31
@@ -5,14 +5,16 @@ const ruleTester = new RuleTester({
parser: '@typescript-eslint/parser',
});

ruleTester.run('ts-ignore', rule, {
ruleTester.run('ban-ts-comment', rule, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was called ts-ignore because it's testing only ts-ignores. That's why the other runs are ts-check, ts-nocheck etc

(Also no idea why I used backticks for these valids - I noticed this while doing invalid-void and facepalmed).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants