Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn on no-poorly-typed-ts-props #1955

Merged
merged 4 commits into from Apr 30, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Apr 29, 2020

Turn it on and fix the issues.
There were a few potential crashes which were fixed by this.

BASED ON #1949

@bradzacher bradzacher added blocked by another PR PRs which are ready to go but waiting on another PR repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 29, 2020
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #1955 into master will decrease coverage by 0.02%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##           master    #1955      +/-   ##
==========================================
- Coverage   93.90%   93.88%   -0.03%     
==========================================
  Files         170      170              
  Lines        7731     7737       +6     
  Branches     2221     2227       +6     
==========================================
+ Hits         7260     7264       +4     
+ Misses        219      218       -1     
- Partials      252      255       +3     
Flag Coverage Δ
#unittest 93.88% <82.14%> (-0.03%) ⬇️
Impacted Files Coverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 97.67% <0.00%> (-2.33%) ⬇️
packages/eslint-plugin/src/util/types.ts 81.21% <71.42%> (-0.39%) ⬇️
...kages/eslint-plugin/src/rules/no-base-to-string.ts 97.95% <100.00%> (+0.04%) ⬆️
...-plugin/src/rules/no-unnecessary-type-arguments.ts 97.87% <100.00%> (+0.04%) ⬆️
...ackages/eslint-plugin/src/rules/prefer-includes.ts 100.00% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-readonly.ts 99.10% <100.00%> (ø)

There are a few things we've built in (like automatically adding a filename) that others might find value in.
Plus I want to use it in the internal plugin.
Simple lint rule to ban usage of properties that introduce bugs.
microsoft/TypeScript#24706
@bradzacher bradzacher force-pushed the turn-on-no-poorly-typed-ts-props branch from 7aedc78 to dfc657d Compare April 29, 2020 20:35
@bradzacher bradzacher merged commit 80d934b into master Apr 30, 2020
@bradzacher bradzacher deleted the turn-on-no-poorly-typed-ts-props branch April 30, 2020 22:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked by another PR PRs which are ready to go but waiting on another PR repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant