Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [unbound-method] fix crash due to missing Intl #2090

Merged
merged 1 commit into from May 25, 2020
Merged

fix(eslint-plugin): [unbound-method] fix crash due to missing Intl #2090

merged 1 commit into from May 25, 2020

Commits on May 24, 2020

  1. fix crash in unbound-method due to missing Intl 

    When Node.js is compiled with the "--with-intl=none" option ( https://nodejs.org/api/intl.html#intl_options_for_building_node_js ) it will not have the Intl global. As a result, any attempt to run eslint would result in an error like:

  TypeError: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.js': Cannot convert undefined or null to object
  Referenced from: /home/dev/web/.eslintrc.js
      at Function.getOwnPropertyNames (<anonymous>)
      at /home/dev/web/node_modules/@typescript-eslint/eslint-plugin/dist/rules/unbound-method.js:91:19

We can silently ignore missing globals as a workaround.
    @eeeee
    eeeee committed May 24, 2020
    Copy the full SHA
    42718d7 View commit details
    Browse the repository at this point in the history