Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): Do not re-export 'ESLint' #2101

Closed
wants to merge 2 commits into from
Closed

fix(experimental-utils): Do not re-export 'ESLint' #2101

wants to merge 2 commits into from

Conversation

SamChou19815
Copy link

Closes #2100.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @SamChou19815!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2101 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
- Coverage   93.44%   93.42%   -0.03%     
==========================================
  Files         171      171              
  Lines        7753     7752       -1     
  Branches     2214     2214              
==========================================
- Hits         7245     7242       -3     
- Misses        243      245       +2     
  Partials      265      265              
Flag Coverage Δ
#unittest 93.42% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
packages/experimental-utils/src/ts-eslint/index.ts 100.00% <ø> (ø)
...ackages/experimental-utils/src/ts-eslint/ESLint.ts 0.00% <0.00%> (-100.00%) ⬇️

@SamChou19815 SamChou19815 changed the title fix: Do not re-export 'ESLint' fix(experimental-utils): Do not re-export 'ESLint' May 25, 2020
@bradzacher
Copy link
Member

Thanks for looking into this!

I've got another solution I'm going to go with which includes an integration test to help prevent this happening in the future - #2105

@bradzacher bradzacher closed this May 25, 2020
@SamChou19815 SamChou19815 deleted the patch-1 branch May 25, 2020 20:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.0.1] Failed to load parser errors with ESLint v6
2 participants