feat(eslint-plugin): [no-unnecessary-boolean-literal-compare] add nullish check option for fixer #2252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #1983, I figured that probably the most clear solution to a nullable-boolean comparison is an actual null check.
Example:
myNullableBoolean === true
. The current fixer will change it tomyNullableBoolean
, which is a bit simpler but doesn't address the ambiguity. IMO, the most clear way to do this ismyNullableBoolean != null && myNullableBoolean
. This is similar in motivation to strict-boolean-expressions.This proposal adds a
fixWithExplicitNullishCheck
option to the rule to modify the behavior of the fixer. You can see what this option does here: https://github.com/zachkirsch/typescript-eslint/blob/zk/explicit-nullable-boolean-cmp/packages/eslint-plugin/docs/rules/no-unnecessary-boolean-literal-compare.md#nullable-boolean-expressions