Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript-estree): support TSv4 labelled tuple members #2378

Merged
merged 1 commit into from Aug 9, 2020
Merged

feat(typescript-estree): support TSv4 labelled tuple members #2378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .prettierignore
View file
Open in desktop
Expand Up @@ -15,3 +15,7 @@ CONTRIBUTORS.md

# Ignore CHANGELOG.md files to avoid issues with automated release job
CHANGELOG.md

# TODO - remove this once prettier supports labelled tuples
packages/scope-manager/tests/fixtures/type-declaration/tuple-labelled.ts
packages/scope-manager/tests/fixtures/type-declaration/tuple-labelled-rest.ts
1 change: 0 additions & 1 deletion packages/eslint-plugin/src/rules/no-unused-vars-experimental.ts
View file
Open in desktop
Expand Up @@ -140,7 +140,6 @@ export default util.createRule<Options, MessageIds>({
case ts.SyntaxKind.ImportSpecifier:
// a namespace import is NOT used, but the default import is used
case ts.SyntaxKind.NamespaceImport:
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
report('Import');
break;

Expand Down
6 changes: 0 additions & 6 deletions packages/eslint-plugin/tests/rules/no-unused-vars-experimental.test.ts
View file
Open in desktop
Expand Up @@ -972,7 +972,6 @@ export function foo([[a]], used) {
messageId: 'unusedWithIgnorePattern',
data: {
name: 'foo',
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
type: 'Import',
pattern: DEFAULT_IGNORED_REGEX,
},
Expand Down Expand Up @@ -1047,7 +1046,6 @@ console.log(named);
messageId: 'unusedWithIgnorePattern',
data: {
name: 'defaultImp',
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
type: 'Import',
pattern: DEFAULT_IGNORED_REGEX,
},
Expand All @@ -1067,7 +1065,6 @@ console.log(named);
messageId: 'unusedWithIgnorePattern',
data: {
name: 'defaultImp',
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
type: 'Import',
pattern: DEFAULT_IGNORED_REGEX,
},
Expand All @@ -1087,7 +1084,6 @@ console.log(defaultImp);
messageId: 'unusedWithIgnorePattern',
data: {
name: 'named',
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
type: 'Import',
pattern: DEFAULT_IGNORED_REGEX,
},
Expand All @@ -1107,7 +1103,6 @@ console.log(defaultImp);
messageId: 'unusedWithIgnorePattern',
data: {
name: 'named',
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
type: 'Import',
pattern: DEFAULT_IGNORED_REGEX,
},
Expand All @@ -1127,7 +1122,6 @@ console.log(named1);
messageId: 'unusedWithIgnorePattern',
data: {
name: 'named2',
// eslint-disable-next-line @typescript-eslint/internal/prefer-ast-types-enum
type: 'Import',
pattern: DEFAULT_IGNORED_REGEX,
},
Expand Down