Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-includes] don't auto fix when test method's argument type doesn't have an 'includes' method #2391

Merged
merged 3 commits into from Aug 13, 2020
Merged

fix(eslint-plugin): [prefer-includes] don't auto fix when test method's argument type doesn't have an 'includes' method #2391

merged 3 commits into from Aug 13, 2020

Commits on Aug 4, 2020

  1. test: add test case to prefer-includes.test.ts 

    Add test cases for RegExp in prefer-includes.test.ts
    @sudalqueen
    sudalqueen committed Aug 4, 2020
    Copy the full SHA
    f24cdf4 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2020

  1. fix: add logic to check the argument type of test method

    @sudalqueen
    sudalqueen committed Aug 13, 2020
    Copy the full SHA
    18d1c1e View commit details
    Browse the repository at this point in the history

  2. fix: edit type checking logic 

    use `getConstrainedTypeAtLocation` method for check argument type of `test` method.
    @sudalqueen
    sudalqueen committed Aug 13, 2020
    Copy the full SHA
    d7891a3 View commit details
    Browse the repository at this point in the history