Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-implied-eval] handle the Function type #2435

Merged
merged 11 commits into from Sep 14, 2020
Merged

fix(eslint-plugin): [no-implied-eval] handle the Function type #2435

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b5cc2c5
test: Function type callback
soobing Aug 22, 2020
755896d
fix: symbol who has 33554497, Function
soobing Aug 22, 2020
e7be083
Merge branch 'master' into fix/no-implied-eval-callback-function
soobing Aug 29, 2020
40b061d
test: revert erased test
soobing Aug 29, 2020
fad7efc
fix: update combination of symbol flags, const
soobing Aug 29, 2020
f571343
Merge branch 'master' into fix/no-implied-eval-callback-function
soobing Sep 6, 2020
84a87b1
Merge branch 'master' into fix/no-implied-eval-callback-function
soobing Sep 7, 2020
2f34f0b
refactor: check function
soobing Sep 7, 2020
096989b
chore: merge base branch
soobing Sep 8, 2020
e07f7d6
Merge branch 'master' into fix/no-implied-eval-callback-function
soobing Sep 9, 2020
ba7e0a4
Merge branch 'master' into fix/no-implied-eval-callback-function
soobing Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/eslint-plugin/src/rules/no-implied-eval.ts
View file
Open in desktop
Expand Up @@ -80,6 +80,19 @@ export default util.createRule({
return true;
}

if (
symbol &&
tsutils.isSymbolFlagSet(
symbol,
ts.SymbolFlags.FunctionScopedVariable |
ts.SymbolFlags.Interface |
ts.SymbolFlags.Transient,
) &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have any good idea to check symbol.flags === 33554497 please let me know. ✨

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better instead to just do something similar to what we've got for checking if the symbol is declared locally or not:

typescript-eslint/packages/eslint-plugin/src/rules/no-implied-eval.ts

Lines 128 to 135 in 2ada5af

const declarations = symbol.getDeclarations() ?? [];
for (const declaration of declarations) {
const sourceFile = declaration.getSourceFile();
if (program.isSourceFileDefaultLibrary(sourceFile)) {
context.report({ node, messageId: 'noFunctionConstructor' });
return;
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradzacher Thank you for review. I updated to check if the symbol is declared locally or not :)

symbol.escapedName === FUNCTION_CONSTRUCTOR
) {
return true;
}

const signatures = checker.getSignaturesOfType(
type,
ts.SignatureKind.Call,
Expand Down
5 changes: 5 additions & 0 deletions packages/eslint-plugin/tests/rules/no-implied-eval.test.ts
View file
Open in desktop
Expand Up @@ -246,6 +246,11 @@ const fn = (foo: () => void) => {
import { Function } from './class';
new Function('foo');
`,
`
const foo = (callback: Function) => {
setTimeout(callback, 0);
};
`,
],

invalid: [
Expand Down