Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-function-type] handle this return #2437

Merged
merged 11 commits into from Sep 14, 2020

Commits on Aug 29, 2020

  1. fix: prefer-function-types handles this

    Tadhg McDonald-Jensen committed Aug 29, 2020
    Copy the full SHA
    553f25f View commit details
    Browse the repository at this point in the history
  2. test: test cases for 'this' in prefer-function-type

    Tadhg McDonald-Jensen committed Aug 29, 2020
    Copy the full SHA
    78a1b37 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. feat: update handling of 'this'

    Tadhg McDonald-Jensen committed Aug 30, 2020
    Copy the full SHA
    79b5af6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Copy the full SHA
    1e0e830 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Copy the full SHA
    206e64e View commit details
    Browse the repository at this point in the history
  2. fix: no longer complains at this inside object literal

    Tadhg McDonald-Jensen committed Sep 3, 2020
    Copy the full SHA
    bde890c View commit details
    Browse the repository at this point in the history
  3. fix: fixed formatting and added test

    Tadhg McDonald-Jensen committed Sep 3, 2020
    Copy the full SHA
    220de56 View commit details
    Browse the repository at this point in the history
  4. revert: reverted to working version

    excluding nested type literals wasn't as strait forward as I thought
    excluding the code to do so because it's not a very common use case so
    I'm not worrying about it.
    Tadhg McDonald-Jensen committed Sep 3, 2020
    Copy the full SHA
    38e8637 View commit details
    Browse the repository at this point in the history
  5. feat: correctly implemented logic to ignore invalid this.

    will now not say "this refers to Foo" on uses of `this` that are invalid
    Tadhg McDonald-Jensen committed Sep 3, 2020
    Copy the full SHA
    8edc462 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Merge remote-tracking branch 'upstream/master'

    Tadhg McDonald-Jensen committed Sep 11, 2020
    Copy the full SHA
    7ca8f5d View commit details
    Browse the repository at this point in the history
  2. fix: addressed comments.

    Tadhg McDonald-Jensen committed Sep 11, 2020
    Copy the full SHA
    c44b273 View commit details
    Browse the repository at this point in the history