Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): [no-redeclare] clearly document type/variable redeclare case #2500

Merged
merged 1 commit into from Sep 6, 2020

Conversation

bradzacher
Copy link
Member

Addresses #2477

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Sep 6, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #2500 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2500      +/-   ##
==========================================
- Coverage   92.82%   92.80%   -0.02%     
==========================================
  Files         290      290              
  Lines        9393     9429      +36     
  Branches     2631     2638       +7     
==========================================
+ Hits         8719     8751      +32     
- Misses        322      323       +1     
- Partials      352      355       +3     
Flag Coverage Δ
#unittest 92.80% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/analyze.ts 72.41% <0.00%> (-4.51%) ⬇️
...ackages/scope-manager/src/referencer/Referencer.ts 93.93% <0.00%> (ø)

@bradzacher bradzacher merged commit bb3e9d6 into master Sep 6, 2020
@bradzacher bradzacher deleted the 2477-no-redeclare-docs branch September 6, 2020 04:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant