Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typescript-estree): remove babel-parser plugins that are enabled by default #2656

Conversation

sosukesuzuki
Copy link
Contributor

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the title chore(typescript-estree): remove babel-parser plugins that is enabled by default test(typescript-estree): remove babel-parser plugins that is enabled by default Oct 9, 2020
@bradzacher bradzacher added the tests anything to do with testing label Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #2656 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
- Coverage   92.84%   92.80%   -0.05%     
==========================================
  Files         294      293       -1     
  Lines        9664     9604      -60     
  Branches     2711     2711              
==========================================
- Hits         8973     8913      -60     
  Misses        326      326              
  Partials      365      365              
Flag Coverage Δ
#unittest 92.80% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/lib/index.ts

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are intentionally

They were there intentionally at some point in time, back when they weren't on by default!
We've just done a bad job of cleaning things up - so thanks for doing this!

@bradzacher bradzacher changed the title test(typescript-estree): remove babel-parser plugins that is enabled by default test(typescript-estree): remove babel-parser plugins that are enabled by default Oct 11, 2020
@bradzacher bradzacher merged commit dfbf115 into typescript-eslint:master Oct 11, 2020
@sosukesuzuki sosukesuzuki deleted the remove-unnecesary-babel-plugins branch October 12, 2020 07:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants