Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): add flag EXPERIMENTAL_useSourceOfProjectReferenceRedirect #2669

Merged
merged 3 commits into from Oct 15, 2020

Commits on Oct 12, 2020

  1. feat(typescript-estree): add flag EXPERIMENTAL_useSourceOfProjectRefe…

    …renceRedirect
    
    See #2094
    This is quick-and-dirty to get this out there for some users to see what sort of perf improvements this squeezes out.
    
    With the flag turned on:
    ```
    bradzacher@bradzacher-mbp typescript-eslint % DEBUG=typescript-eslint:* yarn eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.ts
    yarn run v1.22.4
    $ /Users/bradzacher/github/typescript-eslint/node_modules/.bin/eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.ts
      typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [
      './tsconfig.eslint.json',
      './tests/integration/utils/jsconfig.json',
      './packages/eslint-plugin/tsconfig.json',
      './packages/eslint-plugin-internal/tsconfig.json',
      './packages/eslint-plugin-tslint/tsconfig.json',
      './packages/experimental-utils/tsconfig.json',
      './packages/parser/tsconfig.json',
      './packages/scope-manager/tsconfig.json',
      './packages/shared-fixtures/tsconfig.json',
      './packages/types/tsconfig.json',
      './packages/typescript-estree/tsconfig.json',
      './packages/visitor-keys/tsconfig.json'
    ] +0ms
      typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms
      typescript-eslint:typescript-estree:createWatchProgram File did not belong to any existing programs, moving to create/update. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tsconfig.eslint.json. +0ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tests/integration/utils/jsconfig.json. +1s
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/tsconfig.json. +844ms
      typescript-eslint:typescript-estree:createWatchProgram Found program for file. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +2s
      typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +0ms
      typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [
      './tsconfig.eslint.json',
      './tests/integration/utils/jsconfig.json',
      './packages/eslint-plugin/tsconfig.json',
      './packages/eslint-plugin-internal/tsconfig.json',
      './packages/eslint-plugin-tslint/tsconfig.json',
      './packages/experimental-utils/tsconfig.json',
      './packages/parser/tsconfig.json',
      './packages/scope-manager/tsconfig.json',
      './packages/shared-fixtures/tsconfig.json',
      './packages/types/tsconfig.json',
      './packages/typescript-estree/tsconfig.json',
      './packages/visitor-keys/tsconfig.json'
    ] +5s
      typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +5s
      typescript-eslint:typescript-estree:createWatchProgram Found existing program for file. /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +74ms
      typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +70ms
    ✨  Done in 6.50s.
    ```
    
    With the flag turned off:
    ```
    bradzacher@bradzacher-mbp typescript-eslint % DEBUG=typescript-eslint:* yarn eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.ts
    yarn run v1.22.4
    $ /Users/bradzacher/github/typescript-eslint/node_modules/.bin/eslint ./packages/types/src/index.ts ./packages/eslint-plugin/src/index.ts
      typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [
      './tsconfig.eslint.json',
      './tests/integration/utils/jsconfig.json',
      './packages/eslint-plugin/tsconfig.json',
      './packages/eslint-plugin-internal/tsconfig.json',
      './packages/eslint-plugin-tslint/tsconfig.json',
      './packages/experimental-utils/tsconfig.json',
      './packages/parser/tsconfig.json',
      './packages/scope-manager/tsconfig.json',
      './packages/shared-fixtures/tsconfig.json',
      './packages/types/tsconfig.json',
      './packages/typescript-estree/tsconfig.json',
      './packages/visitor-keys/tsconfig.json'
    ] +0ms
      typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms
      typescript-eslint:typescript-estree:createWatchProgram File did not belong to any existing programs, moving to create/update. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +0ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tsconfig.eslint.json. +1ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/tests/integration/utils/jsconfig.json. +1s
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/tsconfig.json. +976ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin-internal/tsconfig.json. +2s
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/eslint-plugin-tslint/tsconfig.json. +1s
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/experimental-utils/tsconfig.json. +1s
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/parser/tsconfig.json. +961ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/scope-manager/tsconfig.json. +888ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/shared-fixtures/tsconfig.json. +996ms
      typescript-eslint:typescript-estree:createWatchProgram Creating watch program for /users/bradzacher/github/typescript-eslint/packages/types/tsconfig.json. +561ms
      typescript-eslint:typescript-estree:createWatchProgram Found program for file. /users/bradzacher/github/typescript-eslint/packages/types/src/index.ts +567ms
      typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +0ms
      typescript-eslint:typescript-estree:parser parserOptions.project (excluding ignored) matched projects: [
      './tsconfig.eslint.json',
      './tests/integration/utils/jsconfig.json',
      './packages/eslint-plugin/tsconfig.json',
      './packages/eslint-plugin-internal/tsconfig.json',
      './packages/eslint-plugin-tslint/tsconfig.json',
      './packages/experimental-utils/tsconfig.json',
      './packages/parser/tsconfig.json',
      './packages/scope-manager/tsconfig.json',
      './packages/shared-fixtures/tsconfig.json',
      './packages/types/tsconfig.json',
      './packages/typescript-estree/tsconfig.json',
      './packages/visitor-keys/tsconfig.json'
    ] +11s
      typescript-eslint:typescript-estree:createProjectProgram Creating project program for: /Users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +11s
      typescript-eslint:typescript-estree:createWatchProgram Found existing program for file. /users/bradzacher/github/typescript-eslint/packages/eslint-plugin/src/index.ts +64ms
      typescript-eslint:parser:parser Resolved libs from program: [ 'es2017' ] +60ms
    ✨  Done in 12.26s.
    ```
    bradzacher committed Oct 12, 2020
    Copy the full SHA
    0552d19 View commit details
    Browse the repository at this point in the history
  2. spelling

    bradzacher committed Oct 12, 2020
    Copy the full SHA
    ec0151c View commit details
    Browse the repository at this point in the history
  3. nit move comments

    bradzacher committed Oct 12, 2020
    Copy the full SHA
    8ae1895 View commit details
    Browse the repository at this point in the history