Commits on Nov 12, 2020

1. feat(typescript-estree): add parseWithNodeMaps API …

   Ref: prettier/prettier#9636
   
   This allows consumers to reach into the underlying TS AST in cases where our AST doesn't quite solve the use case.
   
   Motivating example:
   
   We don't (currently) error for code unless TS itself throws an error.
   TS is _very_ permissive, but that leads to some weird (and invalid) code we don't error for, and don't include in the AST.
   For example - this is _syntactically_ valid in the TS parser, but they emit a _semantic_ error:
   ```ts
   @decorator
   enum Foo {
     A = 1
   }
   ```
   As it's not a valid place for a decorator - we do not emit its information in the ESTree AST, but as TS treats this as a semantic error - it is parse-time valid.
   This creates weird states for consumers wherein they cannot see a decorator exists there, which can cause them to ignore it entirely.
   For linting - this isn't a problem. But for something like prettier - this means that they'll delete the decorator at format time!
   This is very bad.
   
   Until we implement a solution for #1852 - this will allow consumers to bridge the gap themselves.

   

   bradzacher committed Nov 12, 2020
   Copy the full SHA

   48f0d47 View commit details

   Browse the repository at this point in the history