Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [consistent-indexed-object-style] convert readonly index signature to readonly record #2798

Merged
merged 4 commits into from Nov 25, 2020
Merged

fix(eslint-plugin): [consistent-indexed-object-style] convert readonly index signature to readonly record #2798

merged 4 commits into from Nov 25, 2020

Commits on Nov 22, 2020

  1. fix(eslint-plugin): [consistent-indexed-object-style] Skip readonly i… 

    …ndex signature
    @ryym
    ryym committed Nov 22, 2020
    Copy the full SHA
    816b1bb View commit details
    Browse the repository at this point in the history

  2. docs(eslint-plugin): [consistent-indexed-object-style] Add readonly t… 

    …ype to correct code examples
    @ryym
    ryym committed Nov 22, 2020
    Copy the full SHA
    3212edb View commit details
    Browse the repository at this point in the history

  3. Revert "docs(eslint-plugin): [consistent-indexed-object-style] Add re… 

    …adonly type to correct code examples"

This reverts commit 3212edb.
The rule should replace a readonly index signature with `Readonly<Record>`
instead of ignoring it.
    @ryym
    ryym committed Nov 22, 2020
    Copy the full SHA
    caf36b7 View commit details
    Browse the repository at this point in the history

  4. feat(eslint-plugin): [consistent-indexed-object-style] Convert readon… 

    …ly index signature to Readonly Record type

This replaces the fix of 816b1bb.
Instead of just ignoring the readonly index signature, replace it with
`Readonly<Record<key, value>>` type.
    @ryym
    ryym committed Nov 22, 2020
    Copy the full SHA
    ddd6011 View commit details
    Browse the repository at this point in the history