Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): add default value for parserOptions.projectFolderIgnoreList and deduplicate resolved projects #2819

Merged
merged 1 commit into from Nov 26, 2020

Commits on Nov 26, 2020

  1. fix(typescript-estree): add default value for `parserOptions.projectF…

    …olderIgnoreList` and deduplicate resolved projects
    
    In #2418 I introduced a regression - I forgot to add in the default value for `projectFolderIgnoreList`.
    This means that globs have been matching `node_modules` since the v4.0 release! Oops :(
    
    This PR fixes that.
    It also hoists the tsconfig path canonicalisation up so that we can deduplicate early.
    Previously if you provided a config like `projects: ['./tsconfig.json', './**/tsconfig.json']`, then we would resolve this to `./tsconfig.json` and `tsconfig.json`, then later canonicalise them.
    This meant we'd check that same tsconfig twice!
    By hoisting the canonicalisation, we can deduplicate this early.
    
    Fixes #2814
    bradzacher committed Nov 26, 2020
    Copy the full SHA
    6d15c1a View commit details
    Browse the repository at this point in the history