Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scope-manager): add missing test cases for typeof import #3101

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 23, 2021

tests extracted from #3076

@armano2 armano2 added tests anything to do with testing package: scope-manager Issues related to @typescript-eslint/scope-manager labels Feb 23, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #3101 (db9916d) into master (af5cbd5) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
+ Coverage   92.83%   92.87%   +0.04%     
==========================================
  Files         314      314              
  Lines       10672    10672              
  Branches     3027     3027              
==========================================
+ Hits         9907     9912       +5     
+ Misses        348      344       -4     
+ Partials      417      416       -1     
Flag Coverage Δ
unittest 92.87% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/scope-manager/src/referencer/TypeVisitor.ts 94.68% <0.00%> (+5.31%) ⬆️

@armano2 armano2 merged commit 66dc285 into master Feb 23, 2021
@armano2 armano2 deleted the test/scope-analyzer-typeof-import branch February 23, 2021 22:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: scope-manager Issues related to @typescript-eslint/scope-manager tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants