Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): remove getComments from ESLint SourceCode types #3766

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 21, 2021

Tackles a small part of #3738: the getComments() API is deprecated so we generally don't want to use it.

Ref: eslint/eslint#14744, eslint/eslint#14769

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #3766 (9d29b60) into v5 (a752638) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v5    #3766      +/-   ##
==========================================
- Coverage   92.68%   92.58%   -0.11%     
==========================================
  Files         327      188     -139     
  Lines       11351     8480    -2871     
  Branches     3201     2607     -594     
==========================================
- Hits        10521     7851    -2670     
+ Misses        369      262     -107     
+ Partials      461      367      -94     
Flag Coverage Δ
unittest 92.58% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/experimental-utils/src/ts-eslint/SourceCode.ts 100.00% <ø> (ø)
...e-manager/src/definition/TSEnumMemberDefinition.ts
...e-manager/src/definition/TSModuleNameDefinition.ts
packages/scope-manager/src/lib/dom.ts
...kages/scope-manager/src/lib/es2017.sharedmemory.ts
packages/scope-manager/src/lib/es5.ts
packages/scope-manager/src/lib/es2020.ts
packages/scope-manager/src/scope/ModuleScope.ts
packages/scope-manager/src/lib/esnext.array.ts
...src/definition/ImplicitGlobalVariableDefinition.ts
... and 130 more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 21, 2021 17:39
@bradzacher bradzacher added the breaking change This change will require a new major version to be released label Aug 21, 2021
@bradzacher bradzacher added this to the 5.0.0 milestone Aug 21, 2021
@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:14
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bradzacher bradzacher changed the title chore(experimental-utils): remove getComments feat(experimental-utils): remove getComments from ESLint SourceCode types Aug 22, 2021
@bradzacher bradzacher merged commit 5240538 into typescript-eslint:v5 Aug 22, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-get-comments branch August 22, 2021 16:18
bradzacher pushed a commit that referenced this pull request Sep 3, 2021
bradzacher pushed a commit that referenced this pull request Sep 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants