fix(eslint-plugin): no-type-alias: fix typeof alias erroring #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue with the rule crashing on code like
I thought it was because of the
|
being first, but when I added that test it passed. Seems like it's actually because theTSTypeQuery
node type is never handled. I'm not sure if this is the right fix, though.Also kind of relates to #270. Potential crash isn't caught in compile because of non-null assertion on line 216 in rules/no-type-alias.ts, but that seems like a bigger change.