fix(eslint-plugin): no-floating-promises - support chain expression #3826
Conversation
|
Thanks for the PR, @mwhitworth! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
| await returnsPromise?.(); | ||
| returnsPromise()?.then( | ||
| () => {}, | ||
| () => {}, | ||
| ); | ||
| returnsPromise() | ||
| ?.then(() => {}) | ||
| ?.catch(() => {}); | ||
| returnsPromise()?.catch(() => {}); | ||
| returnsPromise()?.finally(() => {}); |
There was a problem hiding this comment.
aren't all of these valid still?
They all either are awaited, or have a catch/finally to close off the promise.
bradzacher
added
the
awaiting response
|
Fixed in #4096 instead |
I can't see a reason why chain expressions aren't supported -
await undefinedis a no-op, and other than that they behave like member expressions