Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): change TypeScript version range to >=3.2.1 <3.5.0 #399

Merged
merged 3 commits into from Apr 3, 2019
Merged

feat(*): change TypeScript version range to >=3.2.1 <3.5.0 #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2ef272
feat(*): change TypeScript version range to >=3.2.1 <3.5.0
JamesHenry Apr 3, 2019
cafb8f3
feat: convert readonly operator
JamesHenry Apr 3, 2019
76f1388
fix: formatting
JamesHenry Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE/default.md → .github/PULL_REQUEST_TEMPLATE/standard.md
View file
Open in desktop
@@ -1,6 +1,6 @@
---
name: 'Default'
about: Default Pull Request Template
name: 'Standard'
about: Standard Pull Request Template
title: ''
labels: ''
assignees: ''
Expand Down
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE/typescript_version_upgrade.md
View file
Open in desktop
Expand Up @@ -14,5 +14,5 @@ TypeScript version added by this PR: `{{ INSERT_TYPESCRIPT_VERSION }}`
- [ ] I have updated the range value in `packages/typescript-estree/src/parser.ts`
- [ ] I have run the existing tests to make sure they still pass, or made any required updates
- [ ] I have added new tests for the features introduced in this newer version of TypeScript
- New features tests added:
-
- New feature tests added:
- ...
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -74,6 +74,6 @@
"ts-jest": "^24.0.0",
"ts-node": "^8.0.1",
"tslint": "^5.11.0",
"typescript": ">=3.2.1 <3.4.0"
"typescript": ">=3.2.1 <3.5.0"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-plugin/src/util/createRule.ts
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ type CreateRuleMeta<TMessageIds extends string> = {
// This function will get much easier to call when this is merged https://github.com/Microsoft/TypeScript/pull/26349
// TODO - when the above rule lands; add type checking for the context.report `data` property
export function createRule<
TOptions extends Readonly<any[]>,
TOptions extends any[],
TMessageIds extends string,
TRuleListener extends RuleListener = RuleListener
>({
Expand Down