Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to typescript 4.5-rc #4073

Merged
merged 4 commits into from Nov 11, 2021

Conversation

sosukesuzuki
Copy link
Contributor

@sosukesuzuki sosukesuzuki commented Oct 30, 2021

PR Checklist

Overview

updates to TypeScript 4.5 RC.

updates to TypeScript 4.5 Beta.

I know typescript-eslint has the policy that is to implement new features when the RC version is released. The purpose of this pull request is to quickly add support for new features when the RC version is released. So this is still draft.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@sosukesuzuki
Copy link
Contributor Author

One test of typescript-estree fails maybe for microsoft/TypeScript#46577

/*
* The semver package will ignore prerelease ranges, and we don't want to explicitly document every one
* List them all separately here, so we can automatically create the full string
*/
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.4.0-beta', '4.4.1-rc'];
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.5.0-beta'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.5rc is out so we should add this

Suggested change
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.5.0-beta'];
const SUPPORTED_PRERELEASE_RANGES: string[] = ['4.5.0-beta', '4.5.1-rc'];

@sosukesuzuki
Copy link
Contributor Author

I've updated tests to avoid microsoft/TypeScript#46577 (a3a89a7)

@sosukesuzuki sosukesuzuki marked this pull request as ready for review November 3, 2021 10:32
@sosukesuzuki sosukesuzuki changed the title chore: update to typescript 4.5 chore: update to typescript 4.5-rc Nov 3, 2021
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #4073 (8026509) into master (4875cd6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4073   +/-   ##
=======================================
  Coverage   92.73%   92.74%           
=======================================
  Files         334      334           
  Lines       11494    11494           
  Branches     3270     3270           
=======================================
+ Hits        10659    10660    +1     
  Misses        362      362           
+ Partials      473      472    -1     
Flag Coverage Δ
unittest 92.74% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 98.03% <0.00%> (+1.96%) ⬆️

@netlify
Copy link

netlify bot commented Nov 9, 2021

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 8026509

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/618a3965039b0e00089130c2

😎 Browse the preview: https://deploy-preview-4073--typescript-eslint.netlify.app

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Nov 11, 2021
@bradzacher bradzacher merged commit cee6137 into typescript-eslint:master Nov 11, 2021
@sosukesuzuki sosukesuzuki deleted the ts4.5 branch November 11, 2021 07:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants