Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump babel to 7.16.x and update tests #4101

Merged
merged 2 commits into from
Nov 8, 2021
Merged

chore: bump babel to 7.16.x and update tests #4101

merged 2 commits into from
Nov 8, 2021

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Nov 7, 2021 •
edited

Overview

Update babel package to 7.16 and align tests, this change is necessary for #4099 and #3147

closes #4085

@armano2 armano2 added the dependencies Issue about dependencies of the package label Nov 7, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 mentioned this pull request Nov 7, 2021
Closed
3 tasks
@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 0cf5ae3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 16.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 16.x - nx test @typescript-eslint/parser
#000000 Node 16.x - nx test @typescript-eslint/experimental-utils
#000000 Node 16.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager

Sent with 💌 from NxCloud.

@armano2
Update packages/typescript-estree/tests/ast-alignment/utils.ts
0cf5ae3 
Co-authored-by: Josh Goldberg <joshuakgoldberg@outlook.com>
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 7, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

packages/typescript-estree/tests/lib/semanticInfo-singleRun.test.ts Show resolved Hide resolved
@JamesHenry JamesHenry merged commit 51fd16e into master Nov 8, 2021
@JamesHenry JamesHenry deleted the fix-babel-7_16-tests branch November 8, 2021 14:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armano2 @JoshuaKGoldberg @JamesHenry