chore: add some tests and refactor tsconfig path resolution #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
approved these changes
Apr 7, 2019
There was a problem hiding this comment.
Thanks for following up @dsgkirkby, something weird seems to be going on with codecov all of a sudden, I am going to merge this and see if that helps restart things
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per conversation in #361 with @uniqueiniquity, I've pulled these small improvements out of the work there as they're likely worth merging on their own, whereas the rest of that PR likely isn't.
It's notable that the caching test now passes on master, as it didn't when I first wrote it; further confirmation that the change in #367 matches the improvements of #361 (but with much less code change 馃槃).