Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fleshed out experimental-utils usage in Custom Rules docs #4137

Merged
merged 3 commits into from Nov 23, 2021
Merged

docs: fleshed out experimental-utils usage in Custom Rules docs #4137

merged 3 commits into from Nov 23, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds more details around RuleCreator usage, replacing any mention of using rule: RuleModule<...> = ... directly.

Relies on #4136 being merged for withoutDocs.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Nov 14, 2021 •
edited

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: a9526cf

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/6194b695cd6e9d0007fdd126

😎 Browse the preview: https://deploy-preview-4137--typescript-eslint.netlify.app

@nx-cloud
Copy link

nx-cloud bot commented Nov 14, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit a9526cf. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils
#000000 Node 14.x - nx test @typescript-eslint/scope-manager
#000000 Node 14.x - nx test @typescript-eslint/visitor-keys
#000000 Node 14.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
#000000 Node 12.x - nx prebuild @typescript-eslint/types
#000000 Node 12.x - nx prebuild @typescript-eslint/types

Sent with 💌 from NxCloud.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Nov 14, 2021
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 17, 2021 01:17
bradzacher
bradzacher approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant - thanks for this!

@bradzacher bradzacher merged commit 3c89e42 into typescript-eslint:main Nov 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the custom-rules-utils-package branch March 1, 2022 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
No open projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoshuaKGoldberg @bradzacher