refactor(eslint-plugin): [restrict-plus-operands] add better error messages

[lonyele]

PR Checklist

• Addresses an existing issue: suggestion for better error experience
• That issue was marked as accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

came from here
I was going to change it to suggested notNumbersOrStrings naming, but as I think more about it like "what about bigint" or "what about any with invalid". I just made 2 error messages one for "invalid type case" and the other for "any with invalid type case". Still not super satisfied though. probably the limit of my English skill.

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 2c5a46a. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 48 targets

• Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 12.x - nx test @typescript-eslint/eslint-plugin
• Node 16.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 16.x - nx test @typescript-eslint/eslint-plugin
• Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
• Node 14.x - nx test @typescript-eslint/eslint-plugin
• Node 12.x - nx run-many --target=typecheck --all --parallel
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx test @typescript-eslint/parser
• Node 12.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx test @typescript-eslint/utils
• Node 12.x - nx test @typescript-eslint/scope-manager
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 12.x - nx test @typescript-eslint/visitor-keys
• Node 12.x - nx test @typescript-eslint/typescript-estree
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/type-utils
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 14.x - nx test @typescript-eslint/parser
• Node 16.x - nx test @typescript-eslint/utils
• Node 14.x - nx test @typescript-eslint/type-utils
• Node 14.x - nx test @typescript-eslint/utils
• Node 12.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx test @typescript-eslint/scope-manager
• Node 14.x - nx test @typescript-eslint/scope-manager
• Node 16.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/visitor-keys
• Node 14.x - nx test @typescript-eslint/typescript-estree
• Node 16.x - nx test @typescript-eslint/typescript-estree
• Node 14.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 16.x - nx run-many --target=build --all --parallel --exclude website --exclude website
• Node 12.x - nx prebuild @typescript-eslint/types
• Node 14.x - nx prebuild @typescript-eslint/types
• Node 16.x - nx prebuild @typescript-eslint/types

---

Sent with 💌 from NxCloud.

[typescript-eslint]

Thanks for the PR, @lonyele!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[netlify]

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: 2c5a46a

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61e50d4c43170b00072ab1db

😎 Browse the preview: https://deploy-preview-4332--typescript-eslint.netlify.app

[codecov]

Codecov Report

Merging #4332 (2c5a46a) into main (e61e388) will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4332      +/-   ##
==========================================
+ Coverage   94.26%   94.61%   +0.34%     
==========================================
  Files         169      147      -22     
  Lines        9440     7842    -1598     
  Branches     2940     2508     -432     
==========================================
- Hits         8899     7420    -1479     
+ Misses        321      233      -88     
+ Partials      220      189      -31     

Flag	Coverage Δ
unittest	94.61% <100.00%> (+0.34%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/brace-style.ts	95.34% <ø> (ø)
...nt-plugin/src/rules/consistent-type-definitions.ts	97.29% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-exports.ts	97.70% <ø> (ø)
...eslint-plugin/src/rules/consistent-type-imports.ts	94.26% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts	96.29% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts	97.18% <ø> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts	96.87% <ø> (ø)
...rc/rules/indent-new-do-not-use/BinarySearchTree.ts	100.00% <ø> (ø)
...n/src/rules/indent-new-do-not-use/OffsetStorage.ts	100.00% <ø> (ø)
...lugin/src/rules/indent-new-do-not-use/TokenInfo.ts	100.00% <ø> (ø)
... and 144 more

[bradzacher]

thanks for this!