Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [no-shadow] ignoreOnInitialization option #4603

Merged
merged 7 commits into from Mar 31, 2022
Merged

feat(eslint-plugin): [no-shadow] ignoreOnInitialization option #4603

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ede0e15
fix(eslint-plugin): [no-shadow] allow ignoreOnInitialization option
Josh-Cena Feb 27, 2022
49800bb
fix(eslint-plugin): backport upstream changes
Josh-Cena Mar 1, 2022
148d3ef
refactor(eslint-plugin): refactor
Josh-Cena Mar 2, 2022
df2e32e
Merge branch 'master' into no-shadow-option
Josh-Cena Mar 15, 2022
83eff7b
chore: sync eslint type def
Josh-Cena Mar 15, 2022
0eebd0d
Merge branch 'master' into no-shadow-option
Josh-Cena Mar 29, 2022
d39e589
test: fix all test failures
Josh-Cena Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/eslint-plugin/src/rules/no-shadow.ts
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ type Options = [
allow?: string[];
builtinGlobals?: boolean;
hoist?: 'all' | 'functions' | 'never';
ignoreOnInitialization?: boolean;
ignoreTypeValueShadow?: boolean;
ignoreFunctionTypeParameterNameValueShadow?: boolean;
},
Expand Down Expand Up @@ -49,6 +50,9 @@ export default util.createRule<Options, MessageIds>({
type: 'string',
},
},
ignoreOnInitialization: {
type: 'boolean',
},
ignoreTypeValueShadow: {
type: 'boolean',
},
Expand All @@ -68,6 +72,7 @@ export default util.createRule<Options, MessageIds>({
allow: [],
builtinGlobals: false,
hoist: 'functions',
ignoreOnInitialization: false,
ignoreTypeValueShadow: true,
ignoreFunctionTypeParameterNameValueShadow: true,
},
Expand Down