Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): [prefer-nullish-coalescing] add ignoreTernaryTests option #4965

Merged
merged 25 commits into from Jul 23, 2022
Merged

feat(eslint-plugin): [prefer-nullish-coalescing] add ignoreTernaryTests option #4965

merged 25 commits into from Jul 23, 2022

Commits on Jun 11, 2022

  1. feat(eslint-plugin): added ignoreTernaryTests option to prefer-nullis… 

    …h-coalescing rule
    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    a07ac2d View commit details
    Browse the repository at this point in the history

  2. feat(eslint-plugin): added checking of loose equal ternary cases for … 

    …prefer-nullish-coalescing rule
    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    0487bb7 View commit details
    Browse the repository at this point in the history

  3. feat(eslint-plugin): fixed typo in docs for prefer-nullish-coalescing… 

    … rule
    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    33a6053 View commit details
    Browse the repository at this point in the history

  4. feat(eslint-plugin): added more test cases for prefer-nullish-coalesc… 

    …ing rule
    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    b7b0758 View commit details
    Browse the repository at this point in the history

  5. feat(eslint-plugin): added support for MemberExpressions for ignoreTe… 

    …rnaryTests option
    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    42e9737 View commit details
    Browse the repository at this point in the history

  6. refactor(eslint-plugin): cleanup prefer-nullish-coalescing rule

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    61b9680 View commit details
    Browse the repository at this point in the history

  7. test(eslint-plugin): added missing test case for prefer-nullish-coale… 

    …scing rule
    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    40609b1 View commit details
    Browse the repository at this point in the history

  8. chore: removed currently not supported comment 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @jguddas @JoshuaKGoldberg
    jguddas and JoshuaKGoldberg committed Jun 11, 2022
    Copy the full SHA
    e9626e9 View commit details
    Browse the repository at this point in the history

  9. refactor: simplified return statement 

    Co-authored-by: Josh Goldberg <me@joshuakgoldberg.com>
    @jguddas @JoshuaKGoldberg
    jguddas and JoshuaKGoldberg committed Jun 11, 2022
    Copy the full SHA
    81f1a1d View commit details
    Browse the repository at this point in the history

  10. refactor: renamed utilities

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    060002a View commit details
    Browse the repository at this point in the history

  11. refactor: used new utilities in prefer-optional-chain.ts

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    a20e741 View commit details
    Browse the repository at this point in the history

  12. refactor: simplified prefer-nullish-coalescing.ts

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    ee6bbf6 View commit details
    Browse the repository at this point in the history

  13. test: added test case for prefer-nullish-coalescing

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    0726c9d View commit details
    Browse the repository at this point in the history

  14. refactor: renamed message id to preferNullishOverOr

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    c4146c0 View commit details
    Browse the repository at this point in the history

  15. fix: covered edge case where we have two loose comparisons

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    65415e6 View commit details
    Browse the repository at this point in the history

  16. refactor: removed useless .trim

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    dda02a3 View commit details
    Browse the repository at this point in the history

  17. chore: fixed typo

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    cafa047 View commit details
    Browse the repository at this point in the history

  18. test: added more test cases

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    8ee505c View commit details
    Browse the repository at this point in the history

  19. fix: fixed tests

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    119f14d View commit details
    Browse the repository at this point in the history

  20. chore: fixed typo

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    31966ff View commit details
    Browse the repository at this point in the history

  21. test: added more test cases

    @jguddas
    jguddas committed Jun 11, 2022
    Copy the full SHA
    3d0eab1 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. refactor: inlined getOperator and getNodes

    @jguddas
    jguddas committed Jun 13, 2022
    Copy the full SHA
    73034b0 View commit details
    Browse the repository at this point in the history

  2. perf: skip type check if both null and undefined are not checked

    @jguddas
    jguddas committed Jun 13, 2022
    Copy the full SHA
    4ef1ef7 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Merge branch 'main' into feat/eslint-plugin-added-ignoreTernaryTests-… 

    …option-to-prefer-nullish-coalescing-rule
    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 23, 2022
    Copy the full SHA
    3b36d89 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jul 23, 2022
    Copy the full SHA
    67e7ab5 View commit details
    Browse the repository at this point in the history