Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): Add BigInt object type to default ban-types list #4970

Merged
merged 3 commits into from May 14, 2022
Merged

feat(eslint-plugin): Add BigInt object type to default ban-types list #4970

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2086c90
Add BigInt object type to default ban-types list
tduyduc May 13, 2022
cd266e1
Update documentation with bigint type added
tduyduc May 13, 2022
bb7f97a
Merge branch 'main' into patch-1
JoshuaKGoldberg May 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/eslint-plugin/docs/rules/ban-types.md
View file
Open in desktop
Expand Up @@ -105,6 +105,10 @@ const defaultTypes = {
message: 'Use symbol instead',
fixWith: 'symbol',
},
BigInt: {
message: 'Use bigint instead',
fixWith: 'bigint',
},

Function: {
message: [
Expand Down Expand Up @@ -149,6 +153,7 @@ const str: String = 'foo';
const bool: Boolean = true;
const num: Number = 1;
const symb: Symbol = Symbol('foo');
const bigInt: BigInt = 1n;

// use a proper function type
const func: Function = () => 1;
Expand All @@ -169,6 +174,7 @@ const str: string = 'foo';
const bool: boolean = true;
const num: number = 1;
const symb: symbol = Symbol('foo');
const bigInt: bigint = 1n;

// use a proper function type
const func: () => number = () => 1;
Expand Down
4 changes: 4 additions & 0 deletions packages/eslint-plugin/src/rules/ban-types.ts
View file
Open in desktop
Expand Up @@ -66,6 +66,10 @@ const defaultTypes: Types = {
message: 'Use symbol instead',
fixWith: 'symbol',
},
BigInt: {
message: 'Use bigint instead',
fixWith: 'bigint',
},

Function: {
message: [
Expand Down