Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-unused-vars] highlight last write reference #5267

Merged
merged 6 commits into from Jul 18, 2022
Merged

fix(eslint-plugin): [no-unused-vars] highlight last write reference #5267

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b721ee7
fix(eslint-plugin): [no-unused-vars] correct error to report identifi…
armano2 Jun 27, 2022
b1ede81
fix(eslint-plugin): [no-unused-vars] replicate fix from eslint 14335
armano2 Jun 28, 2022
b924bd6
Merge remote-tracking branch 'origin/main' into fix/no-unused-vars-re…
armano2 Jun 28, 2022
cb31168
Merge remote-tracking branch 'origin/main' into fix/no-unused-vars-re…
armano2 Jul 10, 2022
15d1dde
test(eslint-plugin): [no-unused-vars] update tests
armano2 Jul 10, 2022
da543d8
Merge branch 'main' into fix/no-unused-vars-report-identifiers
armano2 Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/eslint-plugin/src/rules/no-unused-vars.ts
View file
Open in desktop
Expand Up @@ -422,13 +422,13 @@ export default util.createRule<Options, MessageIds>({
for (const unusedVar of unusedVars) {
// Report the first declaration.
if (unusedVar.defs.length > 0) {
const writeRef = unusedVar.references.filter(ref => ref.isWrite());
context.report({
node: unusedVar.references.length
? unusedVar.references[unusedVar.references.length - 1]
.identifier
node: writeRef.length
? writeRef[writeRef.length - 1].identifier
: unusedVar.identifiers[0],
messageId: 'unusedVar',
data: unusedVar.references.some(ref => ref.isWrite())
data: writeRef.length
? getAssignedMessageData(unusedVar)
: getDefinedMessageData(unusedVar),
});
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars-eslint.test.ts
View file
Open in desktop
Expand Up @@ -2601,7 +2601,7 @@ myArray = myArray.filter(x => x == 1);
{
...assignedError('myArray'),
line: 3,
column: 11,
column: 1,
armano2 marked this conversation as resolved.
Show resolved Hide resolved
},
],
},
Expand Down
41 changes: 35 additions & 6 deletions packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
View file
Open in desktop
Expand Up @@ -1458,8 +1458,8 @@ namespace Foo {
action: 'defined',
additional: '',
},
line: 4,
column: 15,
line: 2,
column: 11,
},
],
},
Expand Down Expand Up @@ -1490,8 +1490,8 @@ namespace Foo {
action: 'defined',
additional: '',
},
line: 5,
column: 17,
line: 3,
column: 13,
},
],
},
Expand All @@ -1506,7 +1506,8 @@ interface Foo {
errors: [
{
messageId: 'unusedVar',
line: 4,
line: 2,
column: 11,
data: {
varName: 'Foo',
action: 'defined',
Expand All @@ -1523,6 +1524,7 @@ type Foo = Array<Foo>;
{
messageId: 'unusedVar',
line: 2,
column: 6,
armano2 marked this conversation as resolved.
Show resolved Hide resolved
data: {
varName: 'Foo',
action: 'defined',
Expand Down Expand Up @@ -1550,6 +1552,7 @@ export const ComponentFoo = () => {
{
messageId: 'unusedVar',
line: 3,
column: 10,
data: {
varName: 'Fragment',
action: 'defined',
Expand Down Expand Up @@ -1577,6 +1580,7 @@ export const ComponentFoo = () => {
{
messageId: 'unusedVar',
line: 2,
column: 8,
data: {
varName: 'React',
action: 'defined',
Expand Down Expand Up @@ -1604,6 +1608,7 @@ export const ComponentFoo = () => {
{
messageId: 'unusedVar',
line: 2,
column: 8,
data: {
varName: 'React',
action: 'defined',
Expand All @@ -1624,6 +1629,7 @@ declare module 'foo' {
{
messageId: 'unusedVar',
line: 3,
column: 8,
data: {
varName: 'Test',
action: 'defined',
Expand All @@ -1649,6 +1655,7 @@ export namespace Foo {
{
messageId: 'unusedVar',
line: 4,
column: 13,
data: {
varName: 'Bar',
action: 'defined',
Expand All @@ -1658,6 +1665,7 @@ export namespace Foo {
{
messageId: 'unusedVar',
line: 5,
column: 15,
data: {
varName: 'Baz',
action: 'defined',
Expand All @@ -1667,6 +1675,7 @@ export namespace Foo {
{
messageId: 'unusedVar',
line: 6,
column: 17,
data: {
varName: 'Bam',
action: 'defined',
Expand All @@ -1676,6 +1685,7 @@ export namespace Foo {
{
messageId: 'unusedVar',
line: 7,
column: 15,
data: {
varName: 'x',
action: 'assigned a value',
Expand All @@ -1696,7 +1706,8 @@ interface Foo {
errors: [
{
messageId: 'unusedVar',
line: 6,
line: 2,
column: 11,
data: {
varName: 'Foo',
action: 'defined',
Expand All @@ -1705,5 +1716,23 @@ interface Foo {
},
],
},
{
code: `
let x = null;
x = foo(x);
`,
errors: [
{
messageId: 'unusedVar',
line: 3,
column: 1,
data: {
varName: 'x',
action: 'assigned a value',
additional: '',
},
},
],
},
],
});