Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tighter linting #530

Merged
merged 5 commits into from May 16, 2019
Merged

chore: tighter linting #530

merged 5 commits into from May 16, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented May 14, 2019 •
edited

image

blocked by #527 as it's based off of that branch

  • added eslint-plugin-import
    • fixed up dependencies so they're all in the correct packages (there were a lot of common deps that were just in the base package).
    • added typescript as a dev dependency where appropriate (until npm supports the optional peer dependency config, that is)
  • added eslint-plugin-eslint-comments

@bradzacher bradzacher added the blocked by another PR PRs which are ready to go but waiting on another PR label May 14, 2019
@bradzacher bradzacher changed the base branch from master to utils-eslint-scope May 14, 2019 17:31
@bradzacher bradzacher added the enhancement New feature or request label May 14, 2019
@bradzacher bradzacher changed the base branch from utils-eslint-scope to master May 16, 2019 01:12
@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label May 16, 2019
@codecov

This comment has been minimized.

Sign in to view
@bradzacher bradzacher merged commit 508bb41 into master May 16, 2019
@bradzacher bradzacher deleted the tighter-linting branch May 16, 2019 02:45
@bradzacher bradzacher restored the tighter-linting branch May 16, 2019 02:55
bradzacher added a commit that referenced this pull request May 16, 2019
@bradzacher
Revert "chore: tighter linting (#530)"
24976b0 
This reverts commit 508bb41.
@bradzacher bradzacher mentioned this pull request May 16, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bradzacher