Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing placeholders in violation messages for no-unnecessary-type-constraint and no-unsafe-argument (and enable eslint-plugin/recommended rules internally) #5414

Closed

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Aug 2, 2022

Replaced by #5453.

@nx-cloud
Copy link

nx-cloud bot commented Aug 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8ae0404. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Aug 2, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8ae0404
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62e9b2e2e5482600085a57f6
😎 Deploy Preview https://deploy-preview-5414--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bmish bmish closed this Aug 2, 2022
@bmish bmish changed the title twchore: enable eslint-plugin/recommended rules chore: enable eslint-plugin/recommended rules Aug 2, 2022
@bmish bmish changed the title chore: enable eslint-plugin/recommended rules fix: missing placeholders in violation messages for no-unnecessary-type-constraint and no-unsafe-argument (and enable eslint-plugin/recommended rules internally) Aug 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant