Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint-plugin-eslint-plugin to 5.0.5 #5493

Merged

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Aug 17, 2022

PR Checklist

Overview

Upgrade to v5.0.5 of eslint-plugin-eslint-plugin.

This version fixes 4 separate bugs that we had to use disable comments for in #5453. These disable comments have now been removed. Only one disable comment related to this plugin remains.

@nx-cloud
Copy link

nx-cloud bot commented Aug 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 937ebb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Aug 17, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 937ebb8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62fc50b9fe9af00008797c82
😎 Deploy Preview https://deploy-preview-5493--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #5493 (937ebb8) into main (864dbcf) will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5493      +/-   ##
==========================================
+ Coverage   91.36%   91.74%   +0.38%     
==========================================
  Files         132      366     +234     
  Lines        1494    12345   +10851     
  Branches      226     3603    +3377     
==========================================
+ Hits         1365    11326    +9961     
- Misses         65      668     +603     
- Partials       64      351     +287     
Flag Coverage Δ
unittest 91.74% <ø> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 81.09% <ø> (ø)
...ages/eslint-plugin/src/rules/no-empty-interface.ts 100.00% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 92.85% <ø> (ø)
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <ø> (ø)
packages/eslint-plugin/src/rules/return-await.ts 99.05% <ø> (ø)
.../src/rules/sort-type-union-intersection-members.ts 90.74% <ø> (ø)
packages/utils/src/ast-utils/index.ts 25.00% <0.00%> (ø)
...rc/rules/no-unnecessary-boolean-literal-compare.ts 90.36% <0.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts 78.06% <0.00%> (ø)
packages/type-utils/src/getTypeArguments.ts 25.00% <0.00%> (ø)
... and 230 more

@bmish bmish changed the title chore(eslint-plugin): update eslint-plugin-eslint-plugin to 5.0.5 chore(dev-deps): update eslint-plugin-eslint-plugin to 5.0.5 Aug 17, 2022
@bradzacher bradzacher changed the title chore(dev-deps): update eslint-plugin-eslint-plugin to 5.0.5 chore: update eslint-plugin-eslint-plugin to 5.0.5 Aug 17, 2022
@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Aug 17, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!
damngoodstuff

@bradzacher bradzacher merged commit 68c937e into typescript-eslint:main Aug 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants