Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fail tests that log to the console #5533

Merged
merged 4 commits into from Aug 25, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 23, 2022

PR Checklist

Overview

Uses console-fail-test to fail tests that call to console.log, console.warn, etc.

Marking as ready to review because it is, though merging is blocked on #5531.

Example in CI:

Screenshot of ban-ts-comment.test.ts in GitHub Actions with console-fail-tests complaints about failing tests

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Aug 23, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 875ac1f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 23, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 875ac1f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/630688be5468340008ff6318
😎 Deploy Preview https://deploy-preview-5533--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradzacher
Copy link
Member

Eyyy the tests are failing like they should

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 23, 2022 15:13
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bradzacher bradzacher merged commit a315daa into typescript-eslint:main Aug 25, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the console-fail-test branch August 25, 2022 02:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Fail tests on console logs
2 participants